From 337e0223560ed455d8ef1f7bf0f24801ff4555b9 Mon Sep 17 00:00:00 2001 From: Mark Joshwel Date: Fri, 14 Feb 2025 22:10:17 +0800 Subject: [PATCH] game(scripts): standardise CanvasFade --- Game/Assets/Scripts/CanvasFade.cs | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/Game/Assets/Scripts/CanvasFade.cs b/Game/Assets/Scripts/CanvasFade.cs index a3b1c1e..239073b 100644 --- a/Game/Assets/Scripts/CanvasFade.cs +++ b/Game/Assets/Scripts/CanvasFade.cs @@ -1,32 +1,32 @@ /* - Author : Wai Lam - Date : 13/2/2025 - Description : Counting days + * Author: Wai Lam + * Date: 13/2/2025 + * Description: Counting days */ -using System.Collections; -using System.Collections.Generic; -using UnityEngine; -using UnityEngine.SceneManagement; -using TMPro; + using System; +using System.Collections; +using TMPro; +using UnityEngine; public class CanvasFade : MonoBehaviour { public CanvasGroup dayPanel; // Assign the UI Panel public TextMeshProUGUI dayText; // Assign the TextMeshPro UI - - public static event Action OnDayPanelHidden; + private void Start() { if (GameManager.Instance != null) { - int dayNumber = GameManager.Instance.currentDay; + var dayNumber = GameManager.Instance.currentDay; dayText.text = "Day " + dayNumber; } StartCoroutine(FadeOutPanel()); } + public static event Action OnDayPanelHidden; + private IEnumerator FadeOutPanel() { dayPanel.alpha = 1f; @@ -34,8 +34,8 @@ public class CanvasFade : MonoBehaviour yield return new WaitForSeconds(3f); // Display for 3 seconds - float fadeDuration = 1.5f; - float elapsedTime = 0f; + const float fadeDuration = 1.5f; + var elapsedTime = 0f; while (elapsedTime < fadeDuration) { @@ -45,8 +45,7 @@ public class CanvasFade : MonoBehaviour } dayPanel.gameObject.SetActive(false); - - OnDayPanelHidden?.Invoke(); + OnDayPanelHidden?.Invoke(); } -} +} \ No newline at end of file